[Bugfix] Consider the opacity of groups for printing #5485
+2,676
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mind84
force-pushed
the
group_as_layer_opacity
branch
from
c9040a0 to
7abcaf5
Compare
rldhont
added
printing
sponsored development
Gustry
reviewed
Mar 3, 2025
| @@ -552,6 +552,19 @@ export class LayerItemState extends EventDispatcher { | |||
| } | |||
| return this._visibility; | |||
| } | |||
|
|
|||
| /** | |||
| * Calculate total opacity by including also all parent gropus opacity values | |||
There was a problem hiding this comment.
Suggested change
| * Calculate total opacity by including also all parent gropus opacity values | |
| * Calculate total opacity by including also all parent groups opacity values |
| test.describe('Print opacities', () => { | ||
| test.beforeEach(async ({ page }) => { | ||
| const url = '/index.php/view/map/?repository=testsrepository&project=group_as_layer_opacity'; | ||
| await gotoMap(url, page); |
There was a problem hiding this comment.
This gotoMap is deprecated, as "new" tests must use POM https://playwright.dev/docs/pom. Look in "playwright/pages"
You can add some locators about the "print" box, such as the scale, the buttons...
There was a problem hiding this comment.
Please also add the tag @readonly to your new test.
I thinks that's it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
total opacityis considered when printing, instead of the individual layer opacity.By
total opacityI mean the product of opacity of the individual layer with the opacity of the all parent groups (hierarchically),groupAsLayerlayers included.Ticket : #4984
Backport 3.8, 3.9
Funded by Faunalia