Admin - Display if the installation is not complete according to versions in installed modules #5478
+74
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
added
administration pages
run end2end
…ions in installed modules
Gustry
force-pushed
the
installation-not-complete
branch
from
5529dc1 to
2ff8b0d
Compare
nworr
reviewed
Mar 3, 2025
| $data['info']['date'] = $projectInfos->versionDate; | ||
| $data['info']['commit'] = \jApp::config()->commitSha; | ||
|
|
||
| $modules = new ModulesChecker(); |
There was a problem hiding this comment.
it is not necessary to call ModulesChecker in the class Server,
If we want the installation_complete info in the json returned by index.php/view/app/metadata
, we can call the class in the controller view/app controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's checking the version in
project.xmlagainst all "core Lizmap" modules thanks to theinstaller.ini.php.It's to avoid some possible migrations issues
It will be manually backported to 3.9 and 3.8 due to Bootstrap 5.