-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use QJazz in tests #5168
base: master
Are you sure you want to change the base?
Use QJazz in tests #5168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it locally, it works.
Still an issue on CI for now.
Will tags such as 3.34
, 3.40
will be available on Docker hubs later ?
23d1e4b
to
ca13211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Needed QGIS Server plugins are not installed in the current state of this PR. That's why the CI is not working. It was working locally, because my plugins were already existing before.
- Can you remove the script
tests/add_server_plugins.sh
? - In
tests/add_server_plugins.sh
, we need to use to the custom repository for QGIS plugins. Please do the change - Will tags such as
3.34
,3.40
will be available on Docker hubs ? https://hub.docker.com/r/3liz/qjazz/tags
Is-it not missing the mount for QGIS plugins in |
For testing purpose, I have pressed the rebased button, to have latest commits from master. |
Rules for plugins are the following:
|
00fba5e
to
42aefa7
Compare
There is tests checking The qjazz proxy handle standard The path returned in the service response may be changed with the appropriate |
Found that QGIS does not stick to standard and handle headers in case sensitive way, at least for 'X-Qgis-*' headers. |
I cannot check what's wrong on failed test, i need at least the request that failed if this is is a request to the QGIS service. |
@Gustry : please check the timeout error on Playwright test, with proper rights there is no issue locally with the url I can guess from the details. |
4bbaab3
to
51d7be8
Compare
Something is very slow in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is-it a typo ?
Yes, this where we log QGIS opérations. |
Where can I find logs related to failed tests ? |
Can you rebase on top of master, I have merged #5203 All logs are in the artifacts, for example, for the last run, after 194 minutes :(, artifacts are on the page summary https://github.com/3liz/lizmap-web-client/actions/runs/12785872522?pr=5168 at the bottom, direct link to ZIP : https://github.com/3liz/lizmap-web-client/actions/runs/12785872522/artifacts/2434513285 The timestamp in the QGIS Server logs are very slow.
So can you add in your PR
|
I don't understand where I should exacty set this line: shouldn't it be in a job ? It seems wrong to me jush to add the line add the end of the file. |
c45838c
to
48706f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, tests are finally passing.
Last thing to change is the plugin repository to change.
Will tags such as 3.34, 3.40 will be available on Docker hubs ? https://hub.docker.com/r/3liz/qjazz/tags
So you mean when a git tag will be made on qjazz
repository, it will be available on docker hub ?
@dmarteau Discussion we got with @rldhont and @mdouchin : Do you think it's possible to add your work in another docker-compose file ? with inheritance ? |
I don't see the benefit unless making things uneccessary complicated. Just keep that |
QJazz QGIS server in tests.