Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a QGIS desktop version in metadata #4236

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Provide a QGIS desktop version in metadata #4236

merged 1 commit into from
Feb 26, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Feb 26, 2024

Funded by 3Liz

@Gustry Gustry added run end2end If the PR must run end2end tests or not backport release_3_7 labels Feb 26, 2024
@github-actions github-actions bot added this to the 3.8.0 milestone Feb 26, 2024
@Gustry Gustry requested review from rldhont, mdouchin and nworr February 26, 2024 13:24
nworr
nworr approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@nworr nworr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be the method name should explictly tell if the version is recommended or required

refering to the mainconfig section name , it's a required version

lizmap/modules/lizmap/lib/Server/Server.php Show resolved Hide resolved
@Gustry
Copy link
Member Author

Gustry commented Feb 26, 2024

I have rephrased the docstring.
For now it's experimental about "required"/"recommended". I will see later.

@Gustry Gustry merged commit 25c7ee8 into 3liz:master Feb 26, 2024
12 checks passed
@Gustry Gustry deleted the qgis-desktop branch February 26, 2024 15:00
@3liz-bot 3liz-bot mentioned this pull request Feb 26, 2024
Merged
@Gustry Gustry mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nworr nworr nworr approved these changes

@rldhont rldhont Awaiting requested review from rldhont

@mdouchin mdouchin Awaiting requested review from mdouchin

Assignees
No one assigned
Labels
backport release_3_7 run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustry @nworr