-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve snapping functionalities #4215
Conversation
b457ec0
to
4847669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, only docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature. I requested to add some text to help the user
Cypress failing tests : Feature Toolbar in popup - should display working custom action for the popup feature |
f8bd1cc
to
6a9b7fa
Compare
I didn't check carefully your PR yet, sorry, I have noticed you have included a Playwright test with some snapping. Simulating mouse drag etc ? I'm asking for curiosity this because some manual test before each release, one is snapping, because with Cypress, we couldn't integrate it in E2E at that time. CF the current manual test CC @nboisteault |
Hi! I assume that if the geometry requests to the server are consistent with the user's interactions then the snap works as expected. Maybe not a strong assumption, but not so weak and IHMO acceptable. So basically yes, it's a manual testing :) I think I could spend some time to investigate if this can be done with playwright, but not sure about timing. |
Ok, thanks for the explanations. I'm going to test the PR. |
On my screen, new options are quite on the right side, and I have an horizontal scroll bar which is not very good for UX, given the lot of space on the left side : I was also visiting the other snapping project : http://lizmap.local:8130/index.php/view/map?repository=testsrepository&project=form_edition_snap |
Yes, I've placed the new panel in the same control group of the buttons. Initially the center position looks good to me, but in the end I think I will place it left aligned Thanks |
…el to select which layers to snap to
7b8dac6
to
a70069e
Compare
a70069e
to
5b68100
Compare
now you should see the list in the right place Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the UX
A bunch of changes on the snapping functionality:
snap layer
transparent, so that it does not overlap with the map layer symbology.Below the snap button I added a panel with the list of snap layers configured for the layer being edited.
Hidden layers are placed at the bottom of this list and users cannot act on them. When a layer is turned off from
layertree
, then this list is updated accordingly.Users can turn on/off the snap on visible layers. Then, as for previous point, users can refresh the snap to see the changes.
I'm not sure about this last point, I think it could be useful if there are a lot of snap layers configured. If you think so, I can go ahead with e2e tests, otherwise I'll roll back this last feature and only keep the first two.
You can check this functionality on the test project attached to this PR (
form_edition_multilayer_snap.qgs
).Thanks
Funded by Faunalia