-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] JS: Axis orientation projection detection #4208
Conversation
1c9fdac
to
917c965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks, looks easier to understand when it's an acronym
917c965
to
7f8c88a
Compare
Re-implementation of the projection axis orientation detection method. Fixes 3liz#4191 Funded by VSB
95de7bd
to
58a9d48
Compare
…trols` builder option Since jelix 1.8.7, we need to add `deprecatedDeclareFormBeforeControls` builder option because in the `outputHeader` we defined `jFormsJQ.declareForm(jFormsJQ.tForm);` and we use `parent::outputFooter($builder);
58a9d48
to
a115c70
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4208-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 3cd9d93699f5375289ab6a1ff0e6f9ad239c8bf5,a115c70e2f1149f0a4fd55f89bf20f19dc4bcbcb
# Push it to GitHub
git push --set-upstream origin backport-4208-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
Re-implementation of the projection axis orientation detection method.
Funded by VSB