Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Drag and drop form for embedded layers #4204

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mind84
Copy link
Contributor

@mind84 mind84 commented Feb 13, 2024

Drag and drop form configuration is not taken into account for the embedded layers.

This is due to the fact that in the readEditionForms method, the layer configuration is read from the "current" project and not from the embedded project.

To fix this, I did something similar to what I did for this PR.

This time I've also add a cache check. I don't know if it's worth it, since in most cases the modified methods are called before the project cache is set. However, if you think the cache-checking is fine, I could add it to the other methods modified in the previous PR.

I've added unit and playwright tests, since this case is not covered yet.

Thanks

Funded by Faunalia

@github-actions github-actions bot added this to the 3.8.0 milestone Feb 13, 2024
@mind84 mind84 force-pushed the embedded_drag_n_drop branch 2 times, most recently from 5ae2fec to 5c6e733 Compare February 13, 2024 17:11
@Gustry Gustry added editing form run end2end If the PR must run end2end tests or not backport release_3_7 labels Feb 14, 2024
@Gustry
Copy link
Member

Gustry commented Feb 14, 2024

Thanks for the fix.
I'm adding a backport 3.7 ?

@mind84
Copy link
Contributor Author

mind84 commented Feb 14, 2024

Thanks for the fix. I'm adding a backport 3.7 ?

Yes thank you

@Gustry Gustry added the sponsored development This development has been funded label Feb 19, 2024
@mind84 mind84 force-pushed the embedded_drag_n_drop branch from 5c6e733 to e330590 Compare February 19, 2024 15:59
@rldhont rldhont requested a review from mdouchin February 20, 2024 10:17
@mind84 mind84 force-pushed the embedded_drag_n_drop branch from e330590 to 5f5d246 Compare February 20, 2024 17:17
@rldhont rldhont merged commit da33dd8 into 3liz:master Mar 4, 2024
12 checks passed
@mind84 mind84 deleted the embedded_drag_n_drop branch March 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 editing form run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants