[Bugfix] Drag and drop form for embedded layers #4204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag and drop form configuration is not taken into account for the embedded layers.
This is due to the fact that in the
readEditionForms
method, the layer configuration is read from the "current" project and not from the embedded project.To fix this, I did something similar to what I did for this PR.
This time I've also add a
cache check
. I don't know if it's worth it, since in most cases the modified methods are called before the project cache is set. However, if you think the cache-checking is fine, I could add it to the other methods modified in the previous PR.I've added unit and playwright tests, since this case is not covered yet.
Thanks
Funded by Faunalia