-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Enhancing the way Map is managed #4203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rldhont
commented
Feb 13, 2024
- Extent in permalink use precision 6
- target has been added to the event object
- MapState and map are synchronizing
- MapState fires map.state.ready
rldhont
added
map viewer
javascript
Pull requests that update Javascript code
run end2end
If the PR must run end2end tests or not
backport release_3_7
labels
Feb 13, 2024
According to these references https://xkcd.com/2170/, https://i.stack.imgur.com/crFH4.png and https://datatracker.ietf.org/doc/html/rfc7946#section-11.2, coordinates in EPSG:4326 do not require a precision greater than 6.
To be notified that the map is ready a new event `map.state.ready` is fired by MapState. And a new property `isReady` has been added.
rldhont
force-pushed
the
fix-permalink-extent-precision
branch
from
February 14, 2024 08:10
fabebed
to
b6e3f8b
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4203-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 03ffb738425326dcc18c5ee5c8220b5d2617bbe0,1c9d3e87c5cb32ce858c0b06775c1c3a42a24553,66f80648b66507afa8db034f5846791a51230607,b6e3f8ba135cda5f88e9f7e7f7602a2d4c7ad098,2b43af04f0bf8fa6a5a7a6a1e54a35bb8cee177b
# Push it to GitHub
git push --set-upstream origin backport-4203-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release_3_7
failed backport
javascript
Pull requests that update Javascript code
map viewer
run end2end
If the PR must run end2end tests or not
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.