Qgis vector datasource - Fix getting the table for sub-queries with escaped double-quotes #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaped double-quotes
mdouchin
force-pushed
the
fix-datasource-postgresql-subquery
branch
from
1180b0c to
5c81b2b
Compare
|
Unit tests added, approved @mdouchin himself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the table property of a QGIS vector layer, if the table contained a complex sub-query with parenthesis and escaped double-quotes, Lizmap used a truncated version of the full sub-query.
This PR allows to handle this complex queries, with a new PHP unit-test for this use-case
Funded by CIRAD https://www.cirad.fr/