Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release_3_5] [PHP] Get cached Polygon filter for project, layer, login and editing context #3898

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Sep 28, 2023

Manually Backport #3895
Authored by: @rldhont

@rldhont rldhont added enhancement run end2end If the PR must run end2end tests or not php Pull requests that update Php code labels Sep 28, 2023
@github-actions github-actions bot added this to the 3.5.15 milestone Sep 28, 2023
@rldhont
Copy link
Collaborator Author

rldhont commented Sep 28, 2023

@Gustry the requests-metadata-ghaction.js cypress test failed. It is not related.

@Gustry Gustry force-pushed the backport-3895-to-release_3_5 branch from 33a1105 to e539202 Compare September 28, 2023 18:04
@Gustry
Copy link
Member

Gustry commented Sep 28, 2023

It was already fixed in the branch, I just pressed the rebased button ;-)

@rldhont rldhont force-pushed the backport-3895-to-release_3_5 branch from e539202 to a7d34c4 Compare September 29, 2023 06:56
@rldhont
Copy link
Collaborator Author

rldhont commented Sep 29, 2023

@nworr the playwright Input type number test failed.

@nworr
Copy link
Contributor

nworr commented Sep 29, 2023

the feature wasn't backported to 3.5, but unfortunately the test was backported, you can ignore

@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Sep 29, 2023
@rldhont
Copy link
Collaborator Author

rldhont commented Sep 29, 2023

@nworr have I to remove tests/end2end/playwright/edition-form.spec.ts ?

@nworr
Copy link
Contributor

nworr commented Sep 29, 2023

Yes, it seems the whole file contain tests unrelated to 3.5 (wrong backport from @nboisteault ?)

… context

The Polygon filter is provided by QGIS Server. The request could take a long time so the response as to be cached.

Funded by [Conseil Départemental du Calvados](https://www.calvados.fr/accueil.html)
@rldhont rldhont force-pushed the backport-3895-to-release_3_5 branch from 75f0352 to aaafc69 Compare October 2, 2023 08:56
@rldhont rldhont merged commit 43d320c into 3liz:release_3_5 Oct 2, 2023
6 checks passed
@rldhont rldhont deleted the backport-3895-to-release_3_5 branch October 16, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement php Pull requests that update Php code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants