Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing - JS events now return the feature primary key(s) value(s) after save #3877

Merged

Conversation

mdouchin
Copy link
Collaborator

@mdouchin mdouchin commented Sep 13, 2023

This will allow the JS custom scripts to request the feature data after the form has been successfully saved.

The events lizmapeditionfeaturecreated and lizmapeditionfeaturemodified will now have a new property primaryKeys containing an object of the created/modified feature primary key(s) values, e.g. { id: "99" }

Funded by Parc naturel régional du Haut-Jura

@mdouchin mdouchin self-assigned this Sep 13, 2023
@github-actions github-actions bot added this to the 3.7.0 milestone Sep 13, 2023
@mdouchin mdouchin added javascript Pull requests that update Javascript code editing form backport release_3_6 enhancement run end2end If the PR must run end2end tests or not labels Sep 13, 2023
@mdouchin mdouchin force-pushed the edition-return-feature-id-on-creation branch from 747498a to bda5ecf Compare September 15, 2023 07:54
@mdouchin mdouchin marked this pull request as ready for review September 15, 2023 08:03
@Gustry Gustry added the sponsored development This development has been funded label Oct 25, 2023
@mdouchin mdouchin requested a review from rldhont October 25, 2023 15:51
@mdouchin mdouchin marked this pull request as draft October 25, 2023 15:52
@mdouchin
Copy link
Collaborator Author

I must fix the tests

@mdouchin mdouchin force-pushed the edition-return-feature-id-on-creation branch from bda5ecf to 72aabbb Compare November 2, 2023 12:02
@github-actions github-actions bot modified the milestones: 3.7.0, 3.8.0 Nov 2, 2023
@mdouchin mdouchin force-pushed the edition-return-feature-id-on-creation branch 3 times, most recently from 8003718 to 7d88ebd Compare November 2, 2023 14:53
@mdouchin mdouchin marked this pull request as ready for review November 2, 2023 15:19
@mdouchin mdouchin requested a review from nboisteault November 2, 2023 15:19
@rldhont rldhont modified the milestones: 3.8.0, 3.7.0 Nov 2, 2023
…emodified return the feature primary key(s) value(s)
@mdouchin mdouchin force-pushed the edition-return-feature-id-on-creation branch from 7d88ebd to 6e2c715 Compare November 2, 2023 15:52
@github-actions github-actions bot modified the milestones: 3.7.0, 3.8.0 Nov 2, 2023
@mdouchin mdouchin modified the milestones: 3.8.0, 3.7.0 Nov 2, 2023
@mdouchin mdouchin merged commit d66c127 into 3liz:master Nov 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing form enhancement javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants