fix e2e dataviz service

3liz · Aug 31, 2023 · 057c381 · 057c381
1 parent eb5b191
commit 057c381
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lizmap/www/assets/js/dataviz/dataviz.js b/lizmap/www/assets/js/dataviz/dataviz.js
@@ -124,6 +124,12 @@ var lizDataviz = function() {
      *
      */
     async function getPlot(plot_id, exp_filter, target_id) {
+         if ($('#' + target_id).length == 0) {
+                  return;
+              }
+
+              // Show the infinite progress bar
+         $('#' + target_id).prev('.dataviz-waiter:first').show();
 
         exp_filter = typeof exp_filter !== 'undefined' ?  exp_filter : null;
         target_id = typeof target_id !== 'undefined' ?  target_id : new Date().valueOf()+btoa(Math.random()).substring(0,12);
@@ -154,8 +160,8 @@ var lizDataviz = function() {
             }
 
             // Build plot
-            var plot = buildPlot(target_id, dv.plots[plot_id]['cache']);
-            $('#'+target_id).prev('.dataviz-waiter:first').hide();
+            buildPlot(target_id, dv.plots[plot_id]['cache']);
+            $('#' + target_id).prev('.dataviz-waiter:first').hide();
 
             return true;
         }

diff --git a/tests/end2end/cypress/integration/dataviz-ghaction.js b/tests/end2end/cypress/integration/dataviz-ghaction.js
@@ -10,7 +10,7 @@ describe('Dataviz tests', function () {
                      })
                  }).as('getMap')
 
-                 cy.intercept('*request=getPlot*',
+                 cy.intercept('*/dataviz/service*',
                      { middleware: true },
                      (req) => {
                          req.on('before:response', (res) => {
@@ -202,4 +202,4 @@ describe('Dataviz tests', function () {
                  })
              })
          })
-     })
+     })