fix: sanitize subprocess call in sounds.py#2454
Open
orbisai0security wants to merge 1 commit into3b1b:masterfrom
Open
fix: sanitize subprocess call in sounds.py#2454orbisai0security wants to merge 1 commit into3b1b:masterfrom
orbisai0security wants to merge 1 commit into3b1b:masterfrom
Conversation
Automated security fix generated by Orbis Security AI
TonyCrane
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
manimlib/utils/sounds.py.Vulnerability
V-001manimlib/utils/sounds.py:26Description: The sound utility functions use subprocess.Popen to execute system commands for audio playback. Line 37 uses shell=True on Windows, making it directly vulnerable to command injection. Lines 26 and 32 use argument lists but still pass unsanitized file paths that could exploit vulnerabilities in the audio player executables.
Changes
manimlib/utils/sounds.pyVerification
Automated security fix by OrbisAI Security