fix(interactive_scene): handle OverflowError in on_key_press for large key symbols #2396
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, pressing certain system keys (like
Win
,PrtScr
, or special key combinations) inside the interactive window causes anOverflowError: Python int too large to convert to C int
. This fix prevents crashes by safely handling such cases, improving stability when working withInteractiveScene
.Proposed changes
InteractiveScene.on_key_press
:chr(symbol)
in atry/except
.OverflowError
to avoid crashing when key symbols are toolarge.
special keys.
Test
Code:
Result:
Win + PrtScr
.OverflowError
.symbols are ignored).
Before:
After: