Fix x_range slicing in get_area_under_graph to prevent TypeError #2395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix a bug in
get_area_under_graph
where passing the fullgraph.x_range
to
inverse_interpolate
could cause aTypeError
:This happened when
graph.x_range
had more than 2 elements. Slicing thex_range ensures that alpha bounds are calculated correctly and subgraphs
are created reliably.
Proposed changes
graph.x_range
to only the first two elements when passing toinverse_interpolate
:graph.x_range[:2]
.x_range
.Test
Code:
Result:
TypeError
occursBefore:
After: