Misc. clean up #2269
Merged
Misc. clean up #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
3b1b
commented
Dec 12, 2024
3b1b
commented
- Move keybindings to config
- Ensure temporary svg paths for Text are deleted
- Replace DEGREES constant with more succinct DEG
- Remove several no-longer-used functions
- Add preview_frame_while_skipping to scene config
Since the shell.showtraceback is giving some issues
This way it can keep track of it's internal shell; use of get_ipython has a finicky relationship with reloading.
This involved making a few context managers for Scene: temp_record, temp_skip, temp_progress_bar, which seem useful in and of themselves.
It had a number of vestigial functions no longer used, and some setup that could be made more organized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.