Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring 3dstreet editor into core #514

Closed
kfarr opened this issue May 15, 2024 · 1 comment
Closed

bring 3dstreet editor into core #514

kfarr opened this issue May 15, 2024 · 1 comment
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented May 15, 2024

Option4 ← this one
/package.json (global)
/src/editor/ for editor repo

What is “Done?”

  • From npm commands I can run a local dev server with 2 entry points for core and editor
  • From npm commands I can build a production server build with 2 entry points
  • Then I can deploy to firebase

Some notes:

Here are package.json scripts in core

  "scripts": {
    "dev": "budo src/index.js:dist/aframe-street-component.js --port 7001 --live",
    "dist": "webpack",
    "prepublish": "npm run dist",
    "test": "nyc --reporter=lcov --reporter=text mocha --recursive --full-trace",
    "test:watch": "mocha --recursive --full-trace --watch",
    "lint": "semistandard -v | snazzy",
    "lint:tested": "semistandard -v 'src/tested/**/*.js' 'test/**/*.js' | snazzy",
    "lint:fix": "semistandard --fix",
    "start": "npm run dev"

Here are scripts from editor, "X" marks items we could remove:

  "scripts": {
    "start:dev": "webpack serve --config webpack.config.js --mode development --open --hot --progress",
    "start:prod": "serve dist -l 3333",
    "start:build": "webpack --config webpack.prod.config.js --mode production --progress",
    "dist": "npm run dist:max && npm run dist:min",
    "dist:max": "cross-env MINIFY=false npm run start:build",
    "dist:min": "cross-env MINIFY=true npm run start:build",
X    "lint": "npm run lintfile 'src/**/*.js*'",
X    "lint:css": "stylelint src/css/main.css",
X    "lintfile": "eslint",
    "prefirebase": "cp -R assets public && cp {index.html,favicon.ico} public && cp -R dist public",
X    "prepare": "husky install",
X    "prepublish": "npm run dist",
X    "prettier": "prettier --write 'src/**/*.js*'",
X    "test": "jest --watch",
X    "test:ci": "jest",
X    "deploy": "npm run prefirebase && cd public && firebase deploy --only hosting:app3dstreet",
X    "storybook": "storybook dev -p 6006",
X    "build-storybook": "storybook build"

Here is a list of the scripts we need:

  • start dev server --> open index.html that includes both the latest Editor and the latest Core
  • 2 entry points in webpack
  • able to run linting (semistandard, snazzy) across core and editor
  • start dev server --> core-only
  • Migrating / merging the user interface “assets” directory (from /editor/assets/ to /assets/)
  • Moving /editor/public/ into /public/, also /config/ and /examples/*
@kfarr kfarr self-assigned this May 15, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented May 21, 2024

closed by #517

@kfarr kfarr closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant