Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix idx error when do repetition penalty #738

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix idx error when do repetition penalty #738

merged 1 commit into from
Aug 31, 2024

Conversation

niuzheng168
Copy link
Contributor

The idx should be changed when decode phrase, now it's always the one in prefill phrase.

fumiama
fumiama approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fumiama fumiama added bug Something isn't working algorithm Algorithm improvements & issues labels Aug 31, 2024
@fumiama fumiama merged commit 3990f0e into 2noise:dev Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumiama fumiama fumiama approved these changes

Assignees
No one assigned
Labels
algorithm Algorithm improvements & issues bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niuzheng168 @fumiama