Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply toLower before titlecase #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kepler471
Copy link

Addresses #53 .

I have applied toLower before titlecase.

There may be cleaner ways to do this, but I had to pack and unpack for the data to be Text, for toLower.

& T.pack
& T.toLower
& T.unpack

A potential issue may be with toLower changing the string. From the source,

The result string may be longer than the input string. For
instance, "İ" (Latin capital letter I with dot above,
U+0130) maps to the sequence "i" (Latin small letter i, U+0069)
followed by " ̇" (combining dot above, U+0307).

@kepler471
Copy link
Author

Here's a test file this.

@kepler471
Copy link
Author

This will blindly change all text, so if a suggestion is/contains an acronym, or something else intentionally fully capitalised, then the result will be need to be edited.

The change could instead be a new button, which lowers and titlecases the new filename. In this way, the user can decide to format the text only if they need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant