Edit RollingUpdate strategy for nfs-deployment #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trategy of nfs-deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making some changes, I ended up stuck mid-deployment with a Multi-Attach error on the PV/PVC. Because the volume has ReadWriteOnce access mode, it cannot be attached to more than resource simultaneously, and the update strategy was trying to bring up a new pod before taking down the old. Causing the Multi-Attach error and stalemate.
By setting
maxSurgeandmaxUnavailableto one (instead of the default 25%), we permit one more replica than defined, and one replica is permitted to be unavailable during upgrade. This permits the terminating pod to release the volume for the creating pod to bind to.See 2i2c-org/infrastructure#5487 for details.