Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable build-image button while building #80

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Disable build-image button while building #80

merged 3 commits into from
Nov 13, 2024

Conversation

oliverroick
Copy link
Collaborator

@oliverroick oliverroick commented Nov 12, 2024 •
edited
Loading

Fixes #76

  • Adds new state isBuildingImage, which is used to set the disabled property of the build-image button
  • Wraps the image-build state handling in a Promise, which we return from buildImage. This makes it easier in the ImageBuilder component to handle state updates, without having to pass callbacks to buildImage
  • Return Promises instead of using callback function, to make it easier in the ImageBuilder component to handle state updates

@yuvipanda yuvipanda merged commit e1a7af6 into main Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking the 'build image' multiple times starts multiple parallel image builds
2 participants
@oliverroick @yuvipanda