Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide profile select for single-profile configs #52

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Hide profile select for single-profile configs #52

merged 4 commits into from
Jun 6, 2024

Conversation

oliverroick
Copy link
Collaborator

Implements #49

  • Hides the profile-select radio if only one profile is available
  • Changed the label to a div so the semantics don't break when there is no radio-input. Wired the input and label via aria-labelledby
  • Fix the CSS for the profile select flex box to use gap instead of margin-left, so there is no margin when there is no input

@oliverroick oliverroick requested a review from batpad June 4, 2024 04:35
@batpad batpad merged commit ec1610f into main Jun 6, 2024
5 checks passed
@batpad batpad deleted the feature/hide-single-profile-radio branch June 6, 2024 12:39
@batpad batpad mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batpad batpad batpad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverroick @batpad