refs #38, fixes case where choices is empty but unlisted_choice is enabled #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliverroick this got a bit hairy, but I think this was the simplest possible change I could think of to fix the issue and ensure the default handling is correct.
I added a profile list item to the test config, but am seeing some existing tests are failing with duplicate items on the page - which makes sense, but it might be good to get some help from you to fix @oliverroick
@oliverroick maybe easiest to have a quick chat to walk through the fixes and you can maybe make suggestions for doing this better.