-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile select #30
Conversation
Sorry for the delayed review here - had some kerfuffle with my local @oliverroick THIS IS LOOKING SO GOOD! I tested multiple profiles, a few different options, it all seems to work really well! @yuvipanda I have a feeling this is going to make you quite happy :-) . There might be minor things to discuss around the layout and things, I suggest we do that later / ideally when someone can give the whole thing a bit of design thinking. @oliverroick could you look at the |
@oliverroick ah sorry, I noticed a minor issue - Steps to reproduce:
Expected:
Actual:
I think there's two options here:
|
@oliverroick any idea why this is still failing? https://results.pre-commit.ci/run/github/633634408/1714976827.7lLMyqY9Tp-3-1zrtfUllQ - do we need some eslint config or something? |
hmm @oliverroick I see that if I try and run I'll poke around a bit. |
wheee this is exciting :) Thanks @oliverroick and @batpad! |
This PRs main goal is to add profile selection to the profile form. In the progress of implementing the proposed design, I made some fundamental changes to the profile form architecture.
ImageSelect
and turned theResoourceSelect
into a generic component to render profile options