New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add steps to npm install and build to CONTRIBUTING.md #19

Closed

batpad wants to merge 1 commit into 2i2c-org:main from batpad:docs/yarn-build

Collaborator

batpad commented Mar 28, 2024

@yuvipanda - minor docs update:

the CONTRIBUTING.md was missing the steps to npm install and npm run webpack:watch to actually get the form to display on the page.

cc @oliverroick


          add steps to npm install and build to CONTRIBUTING.md

5cdd72e

Member

yuvipanda commented Mar 28, 2024

@batpad the pip install should have automatically done that (see https://github.com/yuvipanda/jupyterhub-fancy-profiles/blob/5874628f4169afbf66eaa40fbdd96f166e23fda0/setup.py#L31). Did it not?

Collaborator Author

batpad commented Mar 28, 2024

@yuvipanda that makes sense!

batpad closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet