-
Notifications
You must be signed in to change notification settings - Fork 12
Add: Autostart #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rtmiz
wants to merge
14
commits into
2i2c-org:main
Choose a base branch
from
rtmiz:auto-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add: Autostart #132
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b38a8a4
Add: Autostart
rtmiz 466e390
Add: auto-start via permalink
rtmiz c9ba410
Updates: Consolidate build and start button into one, add autoStart: …
rtmiz a8d98fa
Add: timeout when autoStarting so the form can properly load
rtmiz 24cced1
Fix: tests, linting. Wrap ProfileForm rendering in form tag for consi…
rtmiz 1378d38
Fix: further linting issues
rtmiz edf25a2
Add: Documentation for Auto-Start feature, nbgitpuller integration fo…
rtmiz 00c2f61
Add: reference to auto start and permalinks in the README.md
rtmiz ad794c6
Merge branch 'main' into auto-start
batpad 5ebf70e
Fix: failing tests, Update: use requestSubmit instead of varying othe…
rtmiz 7cbc138
Revert: last commit requestSubmit changes, uppercase AS in Dockerfile
rtmiz 1a67522
Fix: autostart, Add: disable form during build
rtmiz 082f091
Fix: state not syncing correctly, between different profiles
rtmiz 2f0e792
Update: relocate validation logic to change flow
rtmiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needing to wrap the
<form>around the<ProfileForm>in the tests makes sense to me - since fancy-profiles gets "injected" onto a page that already contains the container<form>tag, the<ProfileForm>expects to be rendered inside an existing<form>- since that does not exist during tests, we add it this way.This looks a little awkward, but makes sense to me. Just giving @hanbyul-here some context while reviewing - not sure if there's a way to do this that feels more elegant, but this seems okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 imo, it is ideal if the test's scope is narrowed enough that the test doesn't have to cover any unnecessary tasks. Most tests were scoped down well enough that it doesn't need additional wrapper. I understand some tests might need this wrapper now since this PR makes form submission this application's responsibility. but I still feel like we can get rid of this additional wrapper for the ones that don't need one?
I think one of the biggest change this PR introduces is the programatic form submission -
There’s something nice about letting HTML handle form submission — it keeps the application’s responsibility focused on processing and cleaning the data. This PR expands that responsibility. That’s not necessarily a bad thing, but we would at least need a test for it.
Maybe we can add an explicit test to check if form submission worked with this additional wrapper?