Skip to content

Commit

Permalink
Merge pull request #79 from yuvipanda/fix-terminal-id
Browse files Browse the repository at this point in the history
Set unique IDs for terminal instances
  • Loading branch information
yuvipanda authored Nov 12, 2024
2 parents b1dd5d1 + bed14b2 commit 88edd10
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/ImageBuilder.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ async function buildImage(repo, ref, term, fitAddon, onImageBuilt) {
}
}

function ImageLogs({ setTerm, setFitAddon }) {
function ImageLogs({ setTerm, setFitAddon, name }) {
const terminalId = `${name}--terminal`;
useEffect(() => {
async function setup() {
const { Terminal } = await import("xterm");
Expand All @@ -68,7 +69,7 @@ function ImageLogs({ setTerm, setFitAddon }) {
});
const fitAddon = new FitAddon();
term.loadAddon(fitAddon);
term.open(document.getElementById("terminal"));
term.open(document.getElementById(terminalId));
fitAddon.fit();
setTerm(term);
setFitAddon(fitAddon);
Expand All @@ -84,7 +85,7 @@ function ImageLogs({ setTerm, setFitAddon }) {
</div>
<div className="profile-option-control-container">
<div className="terminal-container">
<div id="terminal"></div>
<div id={terminalId}></div>
</div>
</div>
</div>
Expand Down Expand Up @@ -212,7 +213,7 @@ export function ImageBuilder({ name }) {
</button>
</div>
<input name={name} type="hidden" value={customImage} />
<ImageLogs setFitAddon={setFitAddon} setTerm={setTerm} />
<ImageLogs setFitAddon={setFitAddon} setTerm={setTerm} name={name} />
</>
);
}

0 comments on commit 88edd10

Please sign in to comment.