Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-health: use CHCS auth provider for staging #4977

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 17, 2024

The JupyterHub CHCS client is a Public Application, meaning it has only a client id and requires PKCE, no client secret.

Not ready for prod since we only have test accounts on CHCS so far.

@minrk minrk requested a review from consideRatio October 17, 2024 12:29
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws jupyter-health No Yes Following helm chart values files were modified: staging.values.yaml

Production deployments

No production hub upgrades will be triggered

@consideRatio
Copy link
Contributor

Manually deploying this, I see the following when pressing login:

image

Is there a way to provide access to 2i2c members to ensure we are able to help debug and support this - ideally by using either github / google identities? This deployment will stand out, because we otherwise have access to hubs as 2i2c employees using github / google identities.

@minrk
Copy link
Contributor Author

minrk commented Oct 17, 2024

Since this is an oauth provider, we would need to create accounts for you on the oauth provider. Either that, or enable both with multiauthenticator, which I'm happy to try as well. That's not in the default image either, but it is proposed. I'm happy to test it here, and potentially merge jupyterhub/zero-to-jupyterhub-k8s#3459

@consideRatio
Copy link
Contributor

@minrk I've pinged a few people in 2i2c about this as I'm not confident on merging this myself since it brings in an exception to other hubs.

@minrk
Copy link
Contributor Author

minrk commented Oct 17, 2024

Makes sense! I'll suggest trying out multiauthenticator, which should be a generic solution for 2i2c, since you could add GitHub login for any deployment where a cluster wants to use credentials where you don't have accounts.

@consideRatio
Copy link
Contributor

I want to avoid putting pressure on z2jh to include multiauthenticator right away to unblock this, so lets reduce that option to having a custom image for jupyter-health where its installed for now.

With that said, I see the following constructive short term choices remain:

  1. Create users for 2i2c employees within this oauth provider
  2. Create a single user for 2i2c employees to impersonate within this oauth provider
  3. Use multiauthenticator with either github or google alongside the jupyter-health specific oauth provider

I've looped in @Gman0909, @aprilmj, and @yuvipanda about this for now in slack. 2i2c internal slack reference https://2i2c.slack.com/archives/C07SJJWVCAD/p1729169838322779

Co-authored-by: Yuvi Panda <[email protected]>
@minrk minrk merged commit 6dfe3b2 into 2i2c-org:main Oct 18, 2024
8 checks passed
@minrk minrk deleted the health-chcs-auth branch October 18, 2024 08:37
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/11400373642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants