-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to default to a basehub infrastructure setup during phase2 of hub deploy #3878
Allow to default to a basehub infrastructure setup during phase2 of hub deploy #3878
Conversation
2c3bffb
to
42a6413
Compare
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
I got carried away, and this PR now does a bit more that I planned initially 😬 :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think its good we work to reduce the differentiation wherever reasonable!
I provided code suggestions to get consistent indentation within commented out blocks of code, and to get consistent indentation between commented out code blocks.
Co-authored-by: Erik Sundell <[email protected]>
When generating the infrastructure files using the deployer, information about basehub/daskhub type was needed.
In order to be able to better separate the deployment phases, we need to remove this requirement.
This PR, defaults to defaulting the deployer to basehub and documents what changes to make in order to accomodate a daskhub (when this information is needed).
Also fixes #2187