Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to default to a basehub infrastructure setup during phase2 of hub deploy #3878

Merged
merged 20 commits into from
Apr 9, 2024

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Mar 28, 2024

When generating the infrastructure files using the deployer, information about basehub/daskhub type was needed.
In order to be able to better separate the deployment phases, we need to remove this requirement.

This PR, defaults to defaulting the deployer to basehub and documents what changes to make in order to accomodate a daskhub (when this information is needed).

Also fixes #2187

@GeorgianaElena GeorgianaElena requested a review from a team as a code owner March 28, 2024 14:53
@GeorgianaElena GeorgianaElena changed the title [WIP] Allow to default to a basehub infrastructure setup during phase2 of hub deploy Allow to default to a basehub infrastructure setup during phase2 of hub deploy Apr 3, 2024
Co-authored-by: Erik Sundell <[email protected]>
@GeorgianaElena
Copy link
Member Author

GeorgianaElena commented Apr 4, 2024

I got carried away, and this PR now does a bit more that I planned initially 😬 :

Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think its good we work to reduce the differentiation wherever reasonable!

I provided code suggestions to get consistent indentation within commented out blocks of code, and to get consistent indentation between commented out code blocks.

terraform/gcp/projects/cluster.tfvars.template Outdated Show resolved Hide resolved
terraform/aws/projects/template.tfvars Outdated Show resolved Hide resolved
terraform/aws/projects/template.tfvars Outdated Show resolved Hide resolved
terraform/gcp/projects/cluster.tfvars.template Outdated Show resolved Hide resolved
terraform/gcp/projects/cluster.tfvars.template Outdated Show resolved Hide resolved
Co-authored-by: Erik Sundell <[email protected]>
@GeorgianaElena GeorgianaElena merged commit 4114bf5 into 2i2c-org:main Apr 9, 2024
35 checks passed
@GeorgianaElena GeorgianaElena deleted the no-more-hub-type branch April 9, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use deployer generate dedicated-cluster in the creation proces of new clusters
2 participants