Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jupyter Health Hubs #3859

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Add Jupyter Health Hubs #3859

merged 7 commits into from
Mar 28, 2024

Conversation

yuvipanda
Copy link
Member

Ref #3796

@yuvipanda yuvipanda requested a review from a team as a code owner March 27, 2024 03:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws jupyter-health Yes Following helm chart values files were modified: enc-support.secret.values.yaml, support.values.yaml Yes Following helm chart values files were modified: staging.values.yaml, enc-staging.secret.values.yaml, common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws jupyter-health prod Following helm chart values files were modified: prod.values.yaml, enc-prod.secret.values.yaml, common.values.yaml

consideRatio
consideRatio reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@consideRatio consideRatio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a init_container override that I think isn't relevant to specify, but otherwise this looks great.

@consideRatio
Copy link
Contributor

Fixed a merge conflict

@consideRatio consideRatio mentioned this pull request Mar 27, 2024
Merged
@yuvipanda
Copy link
Member Author

CI caught that I hadn't added the paid_by_us field. Thanks for working on that, @consideRatio.

@yuvipanda yuvipanda merged commit 4252702 into 2i2c-org:main Mar 28, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8461872614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio left review comments

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @consideRatio