Update the hub decommission issue template #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgibson91
commented
Feb 27, 2024
| - [ ] Remove the associated `config/clusters/<cluster_name>` directory and all its contents | ||
| - Remove the cluster from CI: | ||
| - [ ] [`deploy-hubs.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/.github/workflows/deploy-hubs.yaml) | ||
| - [ ] [`validate-clusters.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/.github/workflows/validate-clusters.yaml) | ||
| - [ ] Remove the cluster from the list of grafana datasources at https://grafana.pilot.2i2c.cloud/datasources | ||
| - [ ] [`deploy-grafana-dashboards.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/.github/workflows/deploy-grafana-dashboards.yaml) |
There was a problem hiding this comment.
We dynamically generate which clusters to validate in a similar way to the deploy-hubs workflow. However, we do hardcode the cluster names in the deploy-grafana-dashboards workflow.
sgibson91
commented
Feb 27, 2024
| - [ ] Remove the associated `config/clusters/<cluster_name>` directory and all its contents | ||
| - Remove the cluster from CI: | ||
| - [ ] [`deploy-hubs.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/.github/workflows/deploy-hubs.yaml) | ||
| - [ ] [`validate-clusters.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/.github/workflows/validate-clusters.yaml) | ||
| - [ ] Remove the cluster from the list of grafana datasources at https://grafana.pilot.2i2c.cloud/datasources |
There was a problem hiding this comment.
I found this step unnecessary as I think deployer grafana central-ds remove already achieves this
consideRatio
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Thank you for taking the time to update these steps!
There is also one missing about uptime-checks I think, which can be done after the cluster.yaml is no longer listed. I think the procedure should be:
This step ought to be common for adding a hub I think, and I suspect we lack this also for that docs.
terraform init
terraform workspace select default
terraform applyI opened #3744 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some gotchas to the template I came across while fulfilling #3689