Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nasa-veda: add bucket permissions to terraform added outside terraform #3722

Merged

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Feb 14, 2024

@freitagb I detected a change in nasa-veda's cloud infra that wasn't reflected in our terraform configuration.

When re-generating credentials (#3723), I had to either delete what was added outside the terraform config in the terraform managed resource (bucket permissions), or I had to add it. I opted to add it to the terraform configuration, and while doing that I also added the same permission for the staging environment.

The change applied outside our terraform configuration was to make an IAM Policy allowing bucket access apply to the bucket sdap-dev-zarr.

@freitagb could you confirm its OK to persist this change to the terraform config for use in both staging/prod?

@consideRatio consideRatio requested a review from a team as a code owner February 14, 2024 08:38
@freitagb
Copy link
Contributor

Thanks @consideRatio. I have been experimenting with access permissions and was looking to push the PR once everything was working as expected. I appreciate you adding it to terraform and agree that we can continue with the push to staging/prod. Should changes need to be made i'll submit a PR with those changes.

@consideRatio consideRatio merged commit bdb2808 into 2i2c-org:master Feb 15, 2024
4 checks passed
@consideRatio
Copy link
Contributor Author

Thank you @freitagb and @yuvipanda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants