2i2c, dask-staging: test against pangeo/pangeo-notebook:latest #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
|
I'm about to create a PR that will cause merge conflicts with this, I'll go for a self-merge! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8169413193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we benefit from leaving this unpinned so that we could fail on changes introduced over time in pangeo/pangeo-notebook. I don't think this will cause us to see failures over time though, but its better we spot them here than our communities spot them I think.
To pin an image tag is more work but also gives us more control on what changes and when, but at the same time if we don't automatically bump the pinned version, we will run into issues over time as well. For example things may be broken between dask-gateway server being updated to modern versions and the dask-gateway client installed in a pinned image from 2022.
I'm open to pinning a 2024 version of pangeo-notebook, but I prefer to see us ping
latestfor this cluster's dask-staging to help us catch issues.