Fix extra case sensitivity in GitHub teams check #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The community reproted an issue with people from the new organization being unable to login. This was the error message, only found in the logs. > Your GitHub team membership is insufficient to launch any server profiles. > > GitHub teams you are a member of that this JupyterHub knows about are > nasa-openscapes-workshops:workshopaccess-2i2c, <others> > > If you are part of additional teams, log out of this JupyterHub and > log back in to refresh that information Looking at the *case* of the error message, we see that our config specifies `nasa-openscapes-workshops:WorkshopAccess-2i2c` while the team name returned to us by GitHub is all lower case instead. GitHub orgs are [not case sensitive](https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#get-an-organization), and it was not clear to me if *teams* are or are not. Nevertheless, I verified that you can not actually create a different team in the same org with the same name but different case. This patch casefolds all the team and org names we use, so comparisons are case insensitive. casefold works for all languages, while calling `.lower()` only works for a subset of languages. Ref 2i2c-org#3695
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
sgibson91
approved these changes
Feb 12, 2024
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7877219028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The community reproted an issue with people from the new organization being unable to login. This was the error message, only found in the logs.
Looking at the case of the error message, we see that our config specifies
nasa-openscapes-workshops:WorkshopAccess-2i2cwhile the team name returned to us by GitHub is all lower case instead.GitHub orgs are not case sensitive, and it was not clear to me if teams are or are not. Nevertheless, I verified that you can not actually create a different team in the same org with the same name but different case.
This patch casefolds all the team and org names we use, so comparisons are case insensitive. casefold works for all languages, while calling
.lower()only works for a subset of languages.Ref #3695