-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudbank: Explicitly specify what nodepools users should go to #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, they still end up on the old 'user' nodepool, and it can not be decomissioned. With this, they will end up on the equivalent 'new' nodepool, and then I can get rid of the old one. I have also had to adjust the CPU limit, as at some point I suppose we switched from 8 CPU nodes to 4 but did not adjust this.
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
This also ensures users don't end up accidentally on one of the large nodepools, which would cost a lot more! |
Self-merging as there aren't any other engineers around until end of year. |
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7253756691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, they still end up on the old 'user' nodepool, and it can not be decomissioned. With this, they will end up on the equivalent 'new' nodepool, and then I can get rid of the old one.
I have also had to adjust the CPU limit, as at some point I suppose we switched from 8 CPU nodes to 4 but did not adjust this.