Collect service labels to be able to use the kube_service_labels metric in Grafana
#3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
sgibson91
approved these changes
Nov 29, 2023
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7043525168 |
GeorgianaElena
changed the title
kube_service_labels metric in Grafana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the fix to #3237.
The
$hubvariable used in Grafana is using alabel_valuesquery, on a service metric calledkube_service_labels. But for the service labels to be available, they need to be allowed listed, because starting with kube-state-metrics > v2.0, by default, the metrics contains only name and namespace labels, and all other needed labels need to be explicitly allowed.What I don't understand why it worked until a month ago, as the v2.0 was released for some time already, but I believe this requirement got tighter with kubernetes/kube-state-metrics#2145 which was released more recently.
Anyway, I've test-deployed this and we got the
$hubvariable back into our dashboards 🎉Closes #3237