-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Central grafana datasources and cli fixes #3450
Merged
GeorgianaElena
merged 10 commits into
2i2c-org:master
from
GeorgianaElena:central-grafana-fix
Nov 30, 2023
Merged
Central grafana datasources and cli fixes #3450
GeorgianaElena
merged 10 commits into
2i2c-org:master
from
GeorgianaElena:central-grafana-fix
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
GeorgianaElena
force-pushed
the
central-grafana-fix
branch
from
November 27, 2023 15:23
6df3d7f
to
1d898ad
Compare
sgibson91
approved these changes
Nov 27, 2023
consideRatio
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wieee @GeorgianaElena, looks great to me!!
This was referenced Nov 28, 2023
GeorgianaElena
force-pushed
the
central-grafana-fix
branch
from
November 30, 2023 08:28
1e56f1a
to
4358eec
Compare
… default database
Ok, going for a merge now 🚀 Thanks for reviewing @consideRatio and @sgibson91! |
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7044058319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510.
This PR:
prometheus
datasource of the 2i2c's Grafana to2i2c
grafana central-ds
to manage the datasources in the central Grafanadeployer grafana update-central-datasources
command that added all clusters in the repo as datasources, in bulk to four individual commands:Note, that "renaming" the
prometheus
data source was a bit tricky:infrastructure/helm-charts/support/values.yaml
Lines 373 to 386 in 5e12d77
deleteDatasources
list entryprometheus
deleteDatasources
entry.deleteDatasources
are first deleted, then whatever is listed underdatasouces
is added.📚 Documentation preview 📚: https://2i2c-pilot-hubs--3450.org.readthedocs.build/en/3450/