-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enabling usage logs on GCS storage buckets & enable for LEAP #3407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the title reflect that this PR adds new gcp specific terraform config as well?
This LGTM, added some trivial code suggestions.
Note that we currently can not actually help hub admins process these | ||
logs - that is *their* responsibility. We can only *enable* this logging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think clarifying responsibility as done here as part of introducing this feature is super important - nice!!!
In https://2i2c.freshdesk.com/a/tickets/1105, we were requested to turn on [usage logs](https://cloud.google.com/storage/docs/access-logs) for the GCP buckets in the LEAP project. This moves that config into terraform, but also makes it clearer that while we can enable this config, we currently can not actually help folks *parse* the logs. But the data format is simple enough that they should be able to.
cd22c10
to
4a7a2ba
Compare
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
Applied and looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wiee nice!
- lifecycle condition should be int - Fix typo in naming usage log bucket Missed pushing this commit as a part of 2i2c-org#3407
@2i2c-org/engineering this could make you see new resources be created like below when doing
|
In https://2i2c.freshdesk.com/a/tickets/1105, we were requested to turn on usage
logs for the GCP buckets in the LEAP project. This moves that config into terraform, but also makes it clearer that while we can enable this config, we currently can not actually help folks parse the logs. But the data format is simple enough that they should be able to.