Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Hub] MUST on Catalyst Project Africa cluster #3399

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

AIDEA775
Copy link
Contributor

@AIDEA775 AIDEA775 commented Nov 10, 2023

This will be deployed to must.af.catalystproject.2i2c.cloud

@AIDEA775 AIDEA775 requested a review from a team as a code owner November 10, 2023 14:27
Copy link

github-actions bot commented Nov 10, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws catalystproject-africa No Yes Following helm chart values files were modified: staging.values.yaml, common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws catalystproject-africa nm-aist Following helm chart values files were modified: nm-aist.values.yaml, common.values.yaml
aws catalystproject-africa must Following helm chart values files were modified: enc-must.secret.values.yaml, common.values.yaml, must.values.yaml

@sgibson91
Copy link
Member

So visiting https://must.af.catalystproject.2i2c.cloud is returning a 404 for me 😕

@AIDEA775
Copy link
Contributor Author

So visiting https://must.af.catalystproject.2i2c.cloud is returning a 404 for me 😕

Okay, so it will be available when it's merged? I edited the PR comment.

Also, do I need to change any other configurations in the load balancer? 🤔

@sgibson91
Copy link
Member

Okay, so it will be available when it's merged?

No, if you've run deployer deploy $CLUSTER_NAME $HUB_NAME locally it should be available immediately. We tend to deploy new hubs manually first and check they work, ask for feedback from the hub champion, before merging, as we can sometimes make tweaks as part of the setup.

If you have deployed locally, then we need to do more investigation as to why this is not working, but I cannot see any obvious issues from the files changed (though I am on my phone).

@AIDEA775
Copy link
Contributor Author

AIDEA775 commented Nov 10, 2023

Fantastic! No, I didn't deploy it locally. Now it's running!

Edit: I just noticed that the logo has white letters, which are not visible with the white background.

@jmunroe
Copy link
Contributor

jmunroe commented Nov 11, 2023

Nice! Before sharing this with the Community Champion, we need to provide a jupyter/scipy image instead of a rocker based image.

Something like

jupyterhub:
  singleuser:
    image:
      # This image specification is likely overridden via the configurator.
      #
      # jupyter/scipy-notebook is maintained at: https://github.com/jupyter/docker-stacks
      # tags can be viewed at: https://hub.docker.com/r/jupyter/scipy-notebook/tags
      name: jupyter/scipy-notebook
      tag: "2023-07-06"

should do it.

@AIDEA775
Copy link
Contributor Author

Aah! I didn't see that. Done!

@jmunroe
Copy link
Contributor

jmunroe commented Nov 14, 2023

After logging in, I get bounced to https://must.af.catalystproject.2i2c.cloud/user/[email protected]/rstudio? (which gives a 404)

I think I should be redirect to https://must.af.catalystproject.2i2c.cloud/user/[email protected]/lab (which does work).

I haven't yet looked at why this occurring.

@sgibson91
Copy link
Member

sgibson91 commented Nov 14, 2023

I think now we have a hub on this cluster using a different image, it makes sense to move the R/RStudio image definition from common.values.yaml file and into the relevant hub-specific values files. I was going to do this after this PR was merged, but we may have to do it beforehand if there's a problem with this hub.

Probably what is happening is that not everything related to the image and setting up R envs is being fully overwritten by the Python image spec.

@sgibson91
Copy link
Member

sgibson91 commented Nov 14, 2023

@jmunroe We are picking up rstudio as the default URL from these lines in common.values.yaml

working_dir: /home/rstudio
default_url: /rstudio

@AIDEA775 I opened AIDEA775#1 which you should be able to merge into this PR. Then if you redeploy, I think the problem James reported will be fixed.

@AIDEA775
Copy link
Contributor Author

Okay, redeployed, and now it's working properly.

Note: The default url is https://must.af.catalystproject.2i2c.cloud/user/[email protected]/tree no /lab.

@AIDEA775
Copy link
Contributor Author

@jmunroe @sgibson91 Any update on this? Can we proceed?

@sgibson91
Copy link
Member

@AIDEA775 Have you commented on the related issue and invited the community champion to try it and provide feedback?

@AIDEA775
Copy link
Contributor Author

The community champion gave the okay. I rebased the branch to maintain a clean history :D

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when you like :)

@AIDEA775 AIDEA775 merged commit b33f8f1 into 2i2c-org:master Nov 29, 2023
6 checks passed
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7034483750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants