Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thresholds from yaml header #28

Closed
wants to merge 2 commits into from
Closed

Remove thresholds from yaml header #28

wants to merge 2 commits into from

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Dec 13, 2023 •
edited
Loading

Relates to #23

This PR removes my earlier attempt to include thresholds in the yaml header. It's more complicated than I thought and at this stage I have other priorities.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@maurolepore
Copy link
Contributor Author

No changes: main never had those thresholds in the yaml header.

@maurolepore maurolepore deleted the rm-thresholds branch December 13, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maurolepore