Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each workflow now uses default *thresholds #141

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Each workflow now uses default *thresholds #141

merged 2 commits into from
Mar 12, 2024

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Mar 12, 2024 •
edited
Loading

Closes #140

This PR changes removes *threshold from the call to each profile*(). This makes it safer to run the workflows 'as is'. Whenever we change the defaults upstream (e.g. tiltIndicator) we don't need to remember to change the workflows.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@maurolepore maurolepore changed the title 'profile_sector*.Rmd' now use default '*threshold' The workflows profile_sector*.Rmd now use default values of *threshold Mar 12, 2024
@maurolepore maurolepore changed the title The workflows profile_sector*.Rmd now use default values of *threshold The workflows profile_sector*.Rmd now use default *thresholds Mar 12, 2024
@maurolepore maurolepore changed the title The workflows profile_sector*.Rmd now use default *thresholds profile_sector*.Rmd now use default *thresholds Mar 12, 2024
@maurolepore maurolepore marked this pull request as ready for review March 12, 2024 21:10
@maurolepore maurolepore changed the title profile_sector*.Rmd now use default *thresholds Each workflow now uses default *thresholds Mar 12, 2024
@maurolepore maurolepore merged commit b737b77 into main Mar 12, 2024
6 checks passed
@maurolepore maurolepore deleted the 140_Use-default-thresholds branch March 12, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use default low_threshold and high_threshold
1 participant
@maurolepore