Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltWorkflow::profile*() are now sensitive to tiltIndicatorAfter_options #135

Merged
merged 25 commits into from
Mar 11, 2024

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Mar 9, 2024

Relates to futureverse/future#134
Relates to 2DegreesInvesting/tiltIndicatorAfter#189

This PR passes options to futures.


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@maurolepore maurolepore force-pushed the profile-now-pass-options-to-futures branch from 845bb65 to cfa95eb Compare March 9, 2024 22:36
@maurolepore maurolepore force-pushed the profile-now-pass-options-to-futures branch from 7ff3456 to e2e48d0 Compare March 11, 2024 00:14
@maurolepore maurolepore marked this pull request as ready for review March 11, 2024 00:20
@maurolepore maurolepore changed the title profile now pass options to futures profile*() now pass options to futures Mar 11, 2024
@maurolepore maurolepore changed the title profile*() now pass options to futures profile*() now pass tiltIndicatorAfter.<options> to futures Mar 11, 2024
@maurolepore maurolepore merged commit bc91746 into main Mar 11, 2024
6 checks passed
@maurolepore maurolepore deleted the profile-now-pass-options-to-futures branch March 11, 2024 00:22
@maurolepore maurolepore changed the title profile*() now pass tiltIndicatorAfter.<options> to futures tiltWorkflow::profile*() are now sensitive to `tiltIndicatorAfter_options Mar 11, 2024
@maurolepore maurolepore changed the title tiltWorkflow::profile*() are now sensitive to `tiltIndicatorAfter_options tiltWorkflow::profile*() are now sensitive to tiltIndicatorAfter_options Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant