Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates add_transition_risk_category function #18

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Creates add_transition_risk_category function #18

merged 2 commits into from
Jun 10, 2024

Conversation

kalashsinghal
Copy link
Contributor

@kalashsinghal kalashsinghal commented Jun 10, 2024 •
edited
Loading

closes #17
relates to #16

Dear @maurolepore,
This is a business logic function which will be exported to tiltIndicatorAfter for completing #16. Please review! Thanks!

TODO

  • Draft the PR title.
  • Link related issue/PR.
  • Draft the PR description.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure all checks pass.
  • Change the PR status from draft to ready.
  • Polish the PR description to reflect it's goal (why not how).
  • Polish the PR title as you'd like others to read it from the git log.
  • Assign a reviewer.

Also if the PR includes user-facing changes:

  • Increment the version number: fledge::update_version()
  • Update the changelog: fledge::update_news()
  • Merge then tag: fledge::tag_version()

maurolepore
maurolepore approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work in creating high-level, reusable components. Thanks!

@kalashsinghal kalashsinghal merged commit 158224c into main Jun 10, 2024
6 checks passed
@kalashsinghal kalashsinghal deleted the 17_add_risk_category_function branch June 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolepore maurolepore maurolepore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create add_transition_risk_category function for assigning risk categories to transition risk scores.
2 participants
@kalashsinghal @maurolepore