Skip to content

Commit

Permalink
rename arguments (#19)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kalashsinghal
kalashsinghal authored Jun 11, 2024
1 parent 21254a0 commit 061f31a
Show file tree
Hide file tree
Showing 6 changed files with 65 additions and 69 deletions.
24 changes: 12 additions & 12 deletions R/add_thresholds_transition_risk.R
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#' Adds low and high thresholds for transition risk score
#'
#' @param emissions_profile_products A dataframe
#' @param all_uuids_scenario_sectors A dataframe
#' @param co2 A dataframe
#' @param all_activities_scenario_sectors A dataframe
#' @param scenarios A dataframe
#'
#' @keywords internal
Expand All @@ -15,21 +15,21 @@
#' library(dplyr)
#' options(readr.show_col_types = FALSE)
#'
#' emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
#' all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
#' co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
#' all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
#' scenarios <- read_csv(toy_sector_profile_any_scenarios())
#'
#' output <- add_thresholds_transition_risk(
#' emissions_profile_products,
#' all_uuids_scenario_sectors,
#' co2,
#' all_activities_scenario_sectors,
#' scenarios
#' )
#' output
add_thresholds_transition_risk <- function(emissions_profile_products,
all_uuids_scenario_sectors,
add_thresholds_transition_risk <- function(co2,
all_activities_scenario_sectors,
scenarios) {
check_crucial_cols(emissions_profile_products, c(col_uuid(), col_co2_footprint()))
check_crucial_cols(all_uuids_scenario_sectors, c(
check_crucial_cols(co2, c(col_uuid(), col_co2_footprint()))
check_crucial_cols(all_activities_scenario_sectors, c(
col_uuid(), col_type(),
col_sector(), col_subsector()
))
Expand All @@ -38,11 +38,11 @@ add_thresholds_transition_risk <- function(emissions_profile_products,
col_year(), col_scenario(), col_targets()
))

epa_profile_ranking <- epa_compute_profile_ranking(emissions_profile_products) |>
epa_profile_ranking <- epa_compute_profile_ranking(co2) |>
select_crucial_ranking()

spa_reduction_targets <- spa_compute_profile_ranking(
all_uuids_scenario_sectors,
all_activities_scenario_sectors,
scenarios
) |>
select_crucial_target()
Expand Down
8 changes: 4 additions & 4 deletions R/add_transition_risk_category.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
#' library(dplyr)
#' options(readr.show_col_types = FALSE)
#'
#' emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
#' all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
#' co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
#' all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
#' scenarios <- read_csv(toy_sector_profile_any_scenarios())
#'
#' transition_risk_thresholds <- add_thresholds_transition_risk(
#' emissions_profile_products,
#' all_uuids_scenario_sectors,
#' co2,
#' all_activities_scenario_sectors,
#' scenarios
#' )
#'
Expand Down
18 changes: 7 additions & 11 deletions man/add_thresholds_transition_risk.Rd
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions man/add_transition_risk_category.Rd
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 34 additions & 34 deletions tests/testthat/test-add_thresholds_transition_risk.R
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
test_that("outputs `NA` tranistion risk thresholds for `NA` transition risk score", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent()) |>
co2 <- read_csv(toy_emissions_profile_products_ecoinvent()) |>
filter(activity_uuid_product_uuid != "76269c17-78d6-420b-991a-aa38c51b45b7")
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors()) |>
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors()) |>
filter(activity_uuid_product_uuid == "76269c17-78d6-420b-991a-aa38c51b45b7")
scenarios <- read_csv(toy_sector_profile_any_scenarios())

output <- add_thresholds_transition_risk(
emissions_profile_products,
all_uuids_scenario_sectors,
co2,
all_activities_scenario_sectors,
scenarios
) |>
filter(activity_uuid_product_uuid == "76269c17-78d6-420b-991a-aa38c51b45b7")
Expand All @@ -20,13 +20,13 @@ test_that("outputs `NA` tranistion risk thresholds for `NA` transition risk scor
})

test_that("low and high tranistion risk thresholds distribute all activities in three equal parts for each benchmark", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
scenarios <- read_csv(toy_sector_profile_any_scenarios())

output <- add_thresholds_transition_risk(
emissions_profile_products,
all_uuids_scenario_sectors,
co2,
all_activities_scenario_sectors,
scenarios
) |>
filter(benchmark_tr_score == "1.5C RPS_2030_isic_4digit")
Expand All @@ -42,68 +42,68 @@ test_that("low and high tranistion risk thresholds distribute all activities in
expect_equal(nrow(filter(output, transition_risk_score > high_threshold)), one_third_number_of_activities)
})

test_that("if `emissions_profile_products` lacks crucial columns, errors gracefully", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
test_that("if `co2` lacks crucial columns, errors gracefully", {
co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
scenarios <- read_csv(toy_sector_profile_any_scenarios())

crucial <- col_uuid()
bad <- select(emissions_profile_products, -all_of(crucial))
expect_error(add_thresholds_transition_risk(bad, all_uuids_scenario_sectors, scenarios), crucial)
bad <- select(co2, -all_of(crucial))
expect_error(add_thresholds_transition_risk(bad, all_activities_scenario_sectors, scenarios), crucial)

crucial <- col_co2_footprint()
bad <- select(emissions_profile_products, -all_of(crucial))
expect_error(add_thresholds_transition_risk(bad, all_uuids_scenario_sectors, scenarios), crucial)
bad <- select(co2, -all_of(crucial))
expect_error(add_thresholds_transition_risk(bad, all_activities_scenario_sectors, scenarios), crucial)
})

test_that("if `all_uuids_scenario_sectors` lacks crucial columns, errors gracefully", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
test_that("if `all_activities_scenario_sectors` lacks crucial columns, errors gracefully", {
co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
scenarios <- read_csv(toy_sector_profile_any_scenarios())

crucial <- col_uuid()
bad <- select(all_uuids_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, bad, scenarios), crucial)
bad <- select(all_activities_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(co2, bad, scenarios), crucial)

crucial <- col_type()
bad <- select(all_uuids_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, bad, scenarios), crucial)
bad <- select(all_activities_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(co2, bad, scenarios), crucial)

crucial <- col_sector()
bad <- select(all_uuids_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, bad, scenarios), crucial)
bad <- select(all_activities_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(co2, bad, scenarios), crucial)

crucial <- col_subsector()
bad <- select(all_uuids_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, bad, scenarios), crucial)
bad <- select(all_activities_scenario_sectors, -all_of(crucial))
expect_error(add_thresholds_transition_risk(co2, bad, scenarios), crucial)
})

test_that("if `scenarios` lacks crucial columns, errors gracefully", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
scenarios <- read_csv(toy_sector_profile_any_scenarios())

crucial <- col_type()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)

crucial <- col_sector()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)

crucial <- col_subsector()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)

crucial <- col_year()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)

crucial <- col_scenario()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)

crucial <- col_targets()
bad <- select(scenarios, -all_of(crucial))
expect_error(add_thresholds_transition_risk(emissions_profile_products, all_uuids_scenario_sectors, bad), crucial)
expect_error(add_thresholds_transition_risk(co2, all_activities_scenario_sectors, bad), crucial)
})
8 changes: 4 additions & 4 deletions tests/testthat/test-add_transition_risk_category.R
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
test_that("if input data lacks crucial columns, errors gracefully", {
emissions_profile_products <- read_csv(toy_emissions_profile_products_ecoinvent())
all_uuids_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
co2 <- read_csv(toy_emissions_profile_products_ecoinvent())
all_activities_scenario_sectors <- read_csv(toy_all_uuids_scenario_sectors())
scenarios <- read_csv(toy_sector_profile_any_scenarios())

input_data <- add_thresholds_transition_risk(
emissions_profile_products,
all_uuids_scenario_sectors,
co2,
all_activities_scenario_sectors,
scenarios
)

Expand Down

0 comments on commit 061f31a

Please sign in to comment.