Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile_sector() now handles case "c" #282

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/polish_sector_profile_product.R
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ polish_sector_profile_product <- function(sp_prod, europages_companies, ecoinven
prepare_inter_sector_profile(sp_prod, europages_companies, ecoinvent_activities, ecoinvent_europages, isic) |>
relocate_sector_profile_product() |>
rename_sector_profile_product() |>
mutate(scenario = recode(.data$scenario, "1.5c rps" = "IPR 1.5c RPS", "nz 2050" = "WEO NZ 2050")) |>
mutate(scenario = ifelse(is.na(scenario), grouped_by, scenario)) |>
mutate(scenario = recode_scenario(.data$scenario)) |>
Comment on lines -14 to +15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I write a custom helper to recode scenario in a more robust way. It may be wrong but the idea may be useful. I'll discuss in the helper itself.

select(-c("matching_certainty_num", "avg_matching_certainty_num", "grouped_by", "type", "extra_rowid")) |>
distinct() |>
rename_118()
Expand Down
3 changes: 1 addition & 2 deletions R/prepare_inter_sector_profile.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ prepare_inter_sector_profile <- function(sp_prod, europages_companies, ecoinvent
left_join(ecoinvent_activities, by = "activity_uuid_product_uuid") |>
left_join(ecoinvent_europages, by = c("country", "main_activity", "clustered", "activity_uuid_product_uuid")) |>
left_join(isic, by = "isic_4digit") |>
add_avg_matching_certainty("completion") |>
exclude_rows("risk_category")
Comment on lines -11 to -12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the main "bug".
This line removes rows where risk_category is NA and therefore drops the rows we would want to output.

add_avg_matching_certainty("completion")
}
5 changes: 5 additions & 0 deletions R/utils-scenario.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
recode_scenario <- function(x) {
out <- gsub("^ipr|^weo", "", x, ignore.case = TRUE)
out <- gsub("_", " ", out)
tolower(trimws(out))
}
Comment on lines +1 to +5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper aims to recode the values of scenario in a more "programatic" way -- trying to avoid using explicit strings and letter-case. The exception here is "ipr" and "weo" -- which we could also eliminate by rewriting the code so that it removes the first word (whatever that is).

If you keep this function do test it because a test suggest we may want something like "ns 2050" but instead we get "ns 2050 2030".

34 changes: 34 additions & 0 deletions tests/testthat/test-profile_sector.R
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,37 @@ test_that("outputs `profile_ranking_avg` at company level", {
company <- unnest_company(out)
expect_true(hasName(company, "reduction_targets_avg"))
})

test_that("given a product in 'ipr', when scenarios has also 'weo', then the product-result includes a 'weo*' `scenario` and maps to `NA` in `sector_profile` (#279, tiltIndicator#739)", {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the test for the specific case associated to this issue. Meeting this expectation breaks other tests so the job is incomplete.

one_type <- "ipr"
companies <- read_csv(toy_sector_profile_companies()) |>
filter(type == one_type) |>
head(1)

scenarios <- read_csv(toy_sector_profile_any_scenarios())
has_two_types <- all(sort(unique(scenarios$type)) %in% c("ipr", "weo"))
stopifnot(has_two_types)

europages_companies <- read_csv(toy_europages_companies())
ecoinvent_activities <- read_csv(toy_ecoinvent_activities())
ecoinvent_europages <- read_csv(toy_ecoinvent_europages())
isic_name <- read_csv(toy_isic_name())

product <- profile_sector(
companies,
scenarios,
europages_companies,
ecoinvent_activities,
ecoinvent_europages,
isic_name
) |>
unnest_product()

# `product` results include `scanario` coming from both "ipr" and "weo"
expect_true(any(grepl(c(ipr = "1.5"), product$scenario)))
expect_true(any(grepl(c(weo = "nz"), product$scenario)))

# All rows where `scenario` comes from "weo" map to `NA` in `sector_profile`
weo <- product |> filter(grepl(c(weo = "nz"), scenario))
expect_true(all(is.na(weo$sector_profile)))
})
Loading