Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude irrelevant columns from europages_companies and ecoinvent_inputs #105

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Exclude irrelevant columns from europages_companies and ecoinvent_inputs #105

merged 1 commit into from
Dec 20, 2023

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Dec 19, 2023 •
edited
Loading

Closes #103

@maurolepore maurolepore changed the title 103 Select columns In profile*() select relevant columns only Dec 19, 2023
@maurolepore maurolepore changed the title In profile*() select relevant columns only Irrelevant columns in europages_companies or ecoinvent_inputs don't pass to the output Dec 19, 2023
@maurolepore maurolepore changed the title Irrelevant columns in europages_companies or ecoinvent_inputs don't pass to the output Irrelevant cols in europages_companies or ecoinvent_inputs aren't output Dec 19, 2023
@maurolepore maurolepore changed the title Irrelevant cols in europages_companies or ecoinvent_inputs aren't output Exclude irrelevant columns from europages_companies and ecoinvent_inputs Dec 19, 2023
@maurolepore maurolepore marked this pull request as ready for review December 19, 2023 19:32
maurolepore
maurolepore commented Dec 19, 2023
View reviewed changes
Copy link
Contributor Author

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some comments about my own changes.

kalashsinghal
kalashsinghal approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@kalashsinghal kalashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurolepore maurolepore merged commit c907955 into main Dec 20, 2023
@maurolepore maurolepore deleted the 103_Select-columns branch December 20, 2023 10:27
@maurolepore maurolepore mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalashsinghal kalashsinghal kalashsinghal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In profile*() drop needless columns
2 participants
@maurolepore @kalashsinghal