Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for tiltToyData#23 #666

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Prepare for tiltToyData#23 #666

merged 3 commits into from
Jan 12, 2024

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Jan 12, 2024 •
edited
Loading

Relates to 2DegreesInvesting/tiltToyData#23

This PR prepares tiltIndicator to update toy data. It simply updates snapshots before the new data is released and skips the snapshot tests unless the toy data is the new one.

I'll merge without review because it's clear that once the toy data is updated the snapshots need to be updated too.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@maurolepore maurolepore marked this pull request as ready for review January 12, 2024 17:24
@maurolepore maurolepore merged commit 4c5036f into main Jan 12, 2024
9 checks passed
@maurolepore maurolepore deleted the prepare-for-ttd23 branch January 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maurolepore