Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emissions_profile*() uses co2$values_to_categorize if present #605

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Nov 12, 2023

Closes #603

This PR prepares tiltIndicator for when values_to_categorize come from "co2". When that happens the code will just use that column. Until then it'll continue to use the internally computed values_to_categorize.

Once https://github.com/2DegreesInvesting/tiltIndicatorBefore/issues/7 is done, then we can remove the code that computes values_to_categorize (#606).


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.
  • Assign a reviewer.

@maurolepore maurolepore changed the title 603 prioritize values to categorize from co2 emissions_profile*() uses .co2$values_to_categorize if it exists Nov 12, 2023
@maurolepore maurolepore changed the title emissions_profile*() uses .co2$values_to_categorize if it exists emissions_profile*() uses values_to_categorize from "co2" if it exists Nov 12, 2023
@maurolepore maurolepore changed the title emissions_profile*() uses values_to_categorize from "co2" if it exists emissions_profile*() uses co2$values_to_categorize if present Nov 12, 2023
@maurolepore maurolepore marked this pull request as ready for review November 13, 2023 06:54
@maurolepore maurolepore merged commit f45790c into main Nov 13, 2023
@maurolepore maurolepore deleted the 603_prioritize-values_to_categorize-from-co2 branch November 13, 2023 06:55
Copy link
Collaborator

@kalashsinghal kalashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maurolepore I just want to remind you that the column name will be profile_ranking and not values_to_categorize. I am mentioning to be sure its not a mistake. Thanks!

@maurolepore
Copy link
Contributor Author

maurolepore commented Nov 16, 2023

Thanks @kalashsinghal, better safe than sorry :-)

This PR was merged before we decided on the new name profile_ranking. But now all instances of values_to_categorize have been renamed to profile_ranking.

#610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emissions_profile*() uses co2$values_to_categorize if present
2 participants