-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emissions_profile*()
uses co2$values_to_categorize
if present
#605
emissions_profile*()
uses co2$values_to_categorize
if present
#605
Conversation
emissions_profile*()
uses .co2$values_to_categorize
if it exists
emissions_profile*()
uses .co2$values_to_categorize
if it existsemissions_profile*()
uses values_to_categorize
from "co2" if it exists
emissions_profile*()
uses values_to_categorize
from "co2" if it existsemissions_profile*()
uses co2$values_to_categorize
if present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maurolepore I just want to remind you that the column name will be profile_ranking
and not values_to_categorize
. I am mentioning to be sure its not a mistake. Thanks!
Thanks @kalashsinghal, better safe than sorry :-) This PR was merged before we decided on the new name |
Closes #603
This PR prepares tiltIndicator for when
values_to_categorize
come from "co2". When that happens the code will just use that column. Until then it'll continue to use the internally computedvalues_to_categorize
.Once https://github.com/2DegreesInvesting/tiltIndicatorBefore/issues/7 is done, then we can remove the code that computes
values_to_categorize
(#606).TODO
EXCEPTIONS