Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs and tests #604

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Improve docs and tests #604

merged 4 commits into from
Nov 12, 2023

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Nov 12, 2023 •
edited
Loading

Relates to #599

This PR completes #599:

  • Documents all additional columns and rows.
  • Tests that what the docs say is true.
  • Tests that missing crucial columns yield an informative error message.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.
  • Assign a reviewer.

@maurolepore maurolepore changed the title Document and test new columns and number of rows Improve docs and tests Nov 12, 2023
@maurolepore maurolepore marked this pull request as ready for review November 12, 2023 14:31
@maurolepore maurolepore merged commit 6dd4b28 into main Nov 12, 2023
8 checks passed
@maurolepore maurolepore deleted the polish-docs-and-tests branch November 12, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maurolepore