grouped_by
now refers to names in "co2"
#601
Merged
+288
−280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #566
This PR makes a change necessary to export
emissions_profile_any_add_values_to_categorize()
as a pre-processing helper (#596).The values of
grouped_by
are now more transparent and less surprising (see related principle) (#601). They now simply refer to the full name of the corresponding columns inthe "co2" dataset (products or inputs) passed to the
emissions_profile*()
functions. For example, passing a column
products$tilt_sector
now yields thevalue "tilt_sector" in
group_by
-- which before was obscurely renamed to "tilt_sec".BEFORE
Created on 2023-11-12 with reprex v2.0.2
NOW
Created on 2023-11-12 with reprex v2.0.2
TODO
EXCEPTIONS